Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): non-continuous recognition timers #40

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

jamsch
Copy link
Owner

@jamsch jamsch commented Oct 9, 2024

This PR fixes two issues with iOS when using continuous: false:

  • On iOS 18 when a final result is detected, recognition should immediately stop to match the Web Speech API spec
  • If interimResults is also turned off, the speech timeout timer shouldn't run out if the user speaks a long sentence without stopping

@jamsch jamsch merged commit 3bf804a into main Oct 9, 2024
2 checks passed
jamsch added a commit that referenced this pull request Oct 9, 2024
* fix(ios): non-continuous recognition timers

* chore: bump version
@jamsch jamsch deleted the fix/ios-non-continuous-recognition branch October 11, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant